fix(spec-specs): Fix early issues from bals release v1.4.0 #1743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added
A-spec-specs
fselmo
force-pushed
the
fix/early-issues-with-v1.4.0
branch
from
bde77c8 to
1c138ca
Compare
- Perform a similar check to balance changes and other tracker methods and keep only the last write.
fselmo
force-pushed
the
fix/early-issues-with-v1.4.0
branch
from
1c138ca to
1b73b73
Compare
Contributor
Author
|
Separate PR to refactor to the testing framework that should've caught these issues for non-bal-specific tests here |
spencer-tb
merged commit 70a7786
into
ethereum:eips/amsterdam/eip-7928
9 of 11 checks passed
spencer-tb
pushed a commit
that referenced
this pull request
Nov 4, 2025
- Perform a similar check to balance changes and other tracker methods and keep only the last write.
spencer-tb
pushed a commit
that referenced
this pull request
Nov 4, 2025
- Perform a similar check to balance changes and other tracker methods and keep only the last write.
spencer-tb
pushed a commit
to spencer-tb/execution-specs
that referenced
this pull request
Nov 4, 2025
…1743) - Perform a similar check to balance changes and other tracker methods and keep only the last write.
fselmo
added a commit
that referenced
this pull request
Nov 4, 2025
- Perform a similar check to balance changes and other tracker methods and keep only the last write.
fselmo
added a commit
that referenced
this pull request
Nov 4, 2025
- Perform a similar check to balance changes and other tracker methods and keep only the last write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
As with other checks in the tracker, update a change to storage writes if already present, preventing double entries.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture